Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
Are we deferring this till 0.9? |
|
yes. it relies on me publishing module-replacements@3 too, which I haven't done yet. |
|
I'll also start on working adding replacements v3 to https://github.com/npmx-dev/vscode-npmx 👍 |
|
does this close #1976? |
No, will be a separate PR for that |
|
| 📦 Package | 📋 Versions |
|---|---|
| h3 | 5 versions
h3@2.0.1-rc.11 h3@2.0.1-rc.16 h3@2.0.1-rc.20 |
| glob | 5 versions
|
| @rolldown/pluginutils | 5 versions
@rolldown/pluginutils@1.0.0-rc.9 |
| @oxc-project/types | 6 versions
|
💡 To find out what depends on a specific package, run: pnpm -r why example-package
📊 Dependency Size Changes
Warning
This PR adds 343.2 kB of new dependencies, which exceeds the threshold of 200 kB.
| 📦 Package | 📏 Size |
|---|---|
| module-replacements@3.0.0-beta.4 | 343.2 kB |
Total size change: 343.2 kB
| mapping: ModuleReplacementMapping | ||
| replacement: ModuleReplacement | ||
| } | null>(`/api/replacements/${name}`) | ||
| return { name, replacement: result?.replacement ?? null, failed: false as const } |
There was a problem hiding this comment.
just noticed this false as const, whats going on there? 👀
shouldn't really be needed afaict. i know you didn't introduce it, but may as well fix it while you're here
There was a problem hiding this comment.
I think it's for
npmx.dev/app/composables/useCompareReplacements.ts
Lines 60 to 63 in 887a131
Module replacements v3
Description
Update
module-replacementsto v3Update
Compare/ReplacementSuggestion.vue,Package/Replacement.vue,npm/useReplacementDependencies.ts,useCompareReplacements.ts,useModuleReplacement.ts,package/[[org]]/[name].vue,replacements/[...pkg].get.tsaccordinglyRemove
"MDN"from localesUpdate existing tests:
a11y.spec.ts,composables/use-replacement-dependencies.spec.ts,composables/use-compare-replacements.spec.tsAdd new test fixture
npm-registry/packuments/strip-ansi.jsonAdd new tests:
e2e/compare-replacements.spec.ts,e2e/package-replacements.spec.tsScreenshots
Simple
Native
Documented
Removal
Compare page